mstorsjo added a comment. Hi @aganea, I'm a but curious about this change - how did you manage to make this work with MSVC? In my experience, this construct doesn't produce warning C4190 (which this silences) with MSVC, but produces error C2526 (which I don't think can be silenced).
See e.g. https://gcc.godbolt.org/z/s1Mr6dPr5 for an example of this construct, which fails with MSVC. (It seems to fail in the same way with all versions ranging from 2010 to 2019.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70830/new/ https://reviews.llvm.org/D70830 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
