JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lldb/include/lldb/Core/Declaration.h:161
+ /// \b false otherwise.
+ bool operator!() const { return !operator bool(); }
+
----------------
Is this actually used? I don't think it's worth adding that if it's not.
================
Comment at: lldb/include/lldb/Core/Declaration.h:198
protected:
- /// Member variables.
- FileSpec m_file; ///< The file specification that points to the
- ///< source file where the declaration occurred.
- uint32_t m_line; ///< Non-zero values indicates a valid line number,
- ///< zero indicates no line number information is available.
-#ifdef LLDB_ENABLE_DECLARATION_COLUMNS
- uint32_t m_column; ///< Non-zero values indicates a valid column number,
- ///< zero indicates no column information is available.
-#endif
+ // Member variables.
+ /// The file specification that points to the source file where the
declaration occurred.
----------------
This is useless.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101556/new/
https://reviews.llvm.org/D101556
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
