shafik added a comment. Herald added a subscriber: JDevlieghere. LGTM, it seems like there a few places where we are not consistently checking `m_impl_up` is valid and other places we are using the conditional operator to check if it is set or not.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101585/new/ https://reviews.llvm.org/D101585 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits