Ericson2314 added inline comments.
================
Comment at: clang-tools-extra/clang-doc/tool/CMakeLists.txt:26
install(FILES ../assets/index.js
- DESTINATION share/clang
+ DESTINATION "${CMAKE_INSTALL_DATADIR}/clang"
COMPONENT clang-doc)
----------------
Ericson2314 wrote:
> compnerd wrote:
> > Why are these quoted but other uses not?
> I confess I have no clue when quoting is required or advisable with CMake. I
> started out converting things by hand and then did some auto-conversions,
> this must have been one of the by-hand ones.
>
> Happy to normalize either way, just tell me which one.
I looked it up,
https://stackoverflow.com/questions/35847655/when-should-i-quote-cmake-variables
says I'm slightly better off quoting all of these so I did.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99484/new/
https://reviews.llvm.org/D99484
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
