Yes, this IMO should eventually be addressed by explicitly exporting each 
meant-to-be-exported function with LLDB_ABI and then changing the line this 
patch adds to use `hidden` instead of `default`.

This patch is meant to be a band-aid until that can be done.

> On Apr 20, 2021, at 11:58 PM, Pavel Labath via Phabricator 
> <revi...@reviews.llvm.org> wrote:
> 
> labath added a comment.
> 
> Is there a way to address this through the preprocessor? We already have the 
> `LLDB_API` macro, which expands to `__declspec(dllexport/import)` on windows. 
> Would expanding it do `__attribute__((visibility("default")))` (or something) 
> on other platforms help with anything?
> 
> 
> Repository:
>  rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D100898/new/
> 
> https://reviews.llvm.org/D100898
> 

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to