clayborg added a comment.

Much of this patch requires all places that took a DWARFDie object now also 
must take an extra parameter. Is there really no way to have DWARFDie be able 
to discover the main unit via its contained DWARFUnit?  DWARFDie objects are 
transient, so they can contain more information that just what they currently 
contain:

  class DWARFDie {
    DWARFUnit *U = nullptr;
    const DWARFDebugInfoEntry *Die = nullptr;
  };

Can we add a new "DWARFUnit *MU;" to the DWARFDie class? Is there really not 
way to ask the contained "U" DWARFUnit member for the main unit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96236/new/

https://reviews.llvm.org/D96236

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to