mgorny marked 4 inline comments as done. mgorny added inline comments.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3562-3567 + (process_features & NativeProcessProtocol::Extension::fork) == + NativeProcessProtocol::Extension::fork) + m_fork_events_supported = true; + else if (x == "vfork-events+" && + (process_features & NativeProcessProtocol::Extension::vfork) == + NativeProcessProtocol::Extension::vfork) ---------------- mgorny wrote: > labath wrote: > > Maybe drop the `== Extension::[v]fork` part? > Can't do that, `enum class` doesn't convert to `bool`. In fact, I tried a few > more or less crazy ideas to make this work, and none worked ;-). The next best thing I was able to do is check `!= NativeProcessProtocol::Extension()` which is a little bit shorter. Maybe I could try adding `operator==` and `!=` against, say, `nullptr` or some special constant? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100153/new/ https://reviews.llvm.org/D100153 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
