mgorny marked 2 inline comments as done. mgorny added inline comments.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1310-1311 + "QStartNoAckMode+", + "QThreadSuffixSupported+", + "QListThreadsInStopReply+", + "qEcho+", ---------------- labath wrote: > I think that these two should also be llgs-specific. I actually left them here because the respective `Handle_QThreadSuffixSupported` and `Handle_QListThreadsInStopReply` methods are also in common. ================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h:151 + virtual std::vector<std::string> + HandleFeatures(const llvm::ArrayRef<llvm::StringRef> client_features); + ---------------- labath wrote: > this `const` is useless Yeah, I probably meant to do `const ...&` but I guess it doesn't matter much for `ArrayRef`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100140/new/ https://reviews.llvm.org/D100140 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
