JDevlieghere added a comment.
LGTM with a little nit. Please `clang-format` the patch before landing.
================
Comment at:
lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.h:89-100
+ // There are two routines in the ObjC runtime that tagged pointer clients
+ // can call to get the value from their tagged pointer, one that retrieves
+ // it as an unsigned value and one a signed value. These two
+ // GetTaggedPointerInfo methods mirror those two ObjC runtime calls.
virtual bool GetTaggedPointerInfo(uint64_t *info_bits = nullptr,
uint64_t *value_bits = nullptr,
uint64_t *payload = nullptr) = 0;
----------------
Please make this a Doxygen comment and include both methods in a group.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99694/new/
https://reviews.llvm.org/D99694
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
