jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

Raphael is right.  The default values of the 
target.process.thread.step-avoid-regexp are set such that if lldb finds itself 
in a function inlined from std:: it will automatically step back out.  This 
test is testing that (among other things).  The fact that the test is failing 
means that something in how your compiler is generating symbols is defeating 
this.  Maybe it's emitting the std:: symbols in such a way that the regexp 
isn't matching them?  Maybe the inline records in the DWARF are confusing lldb 
somehow?

In any case, changing the test is not the right resolution, if you are stopping 
in a std::string constructor that is a real failure.

Our test runner allow you to x-fail a test based on compiler and compiler 
version.  In fact this test is x-failed for icc because of some other 
optimizations that compiler does.  So if you're trying to get a clean run it 
would be fine to file a bug about this failure, then add an 
expectedFailureAll(compiler="ssas", bugnumber="<BUG_NUMBER>") to the test, and 
come back and fix the behavior when you or somebody else working on this 
compiler gets around to it.  Or of course, figure out why the behavior is 
incorrect with the ssas output, and fix that, if you have the time for that now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99331/new/

https://reviews.llvm.org/D99331

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to