JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
A few nits but the change itself looks sound. ================ Comment at: lldb/source/Breakpoint/BreakpointOptions.cpp:457 + // If a synchronous callback is called at async time, we will say we + // should stop, we're really expression no opinion about stopping, and + // the StopInfoBreakpoint::PerformAction will note whether an async ---------------- s/expression/expressing/ ================ Comment at: lldb/source/Breakpoint/BreakpointOptions.cpp:459 + // the StopInfoBreakpoint::PerformAction will note whether an async + // callback had already made a claim to stop or not based on the incoming + // values of m_should_stop & m_should_stop_is_valid. ---------------- ================ Comment at: lldb/test/API/functionalities/stop-on-sharedlibrary-load/Makefile:1 +CXX_SOURCES := main.cpp +USE_LIBDL := 1 ---------------- Not that it matters, but I guess this could as well be a C test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98914/new/ https://reviews.llvm.org/D98914 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
