mgorny added inline comments.

================
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2026
+llvm::Error NativeProcessLinux::SetEnabledExtensions(uint32_t flags) {
+  return llvm::createStringError(llvm::inconvertibleErrorCode(),
+                                 "Not implemented");
----------------
This is not intended to send errors like this, I've just added it to test 
logging.


================
Comment at: 
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:187
       &GDBRemoteCommunicationServerLLGS::Handle_QPassSignals);
+  RegisterMemberFunctionHandler(
+      StringExtractorGDBRemote::eServerPacketType_qSupported,
----------------
@labath, I'm not convinced this is the best way of doing it. Do you have any 
suggestions?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98822/new/

https://reviews.llvm.org/D98822

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to