labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Looks good. ================ Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf5-line-strp.s:51-54 + .uleb128 0x3 # (DIE (0x4c) DW_TAG_base_type) + .byte 0x4 # DW_AT_byte_size + .byte 0x5 # DW_AT_encoding + .ascii "int\0" # DW_AT_name ---------------- If you make the function return type `void`, this will go away. ================ Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf5-line-strp.s:114-125 + .section .debug_aranges,"",@progbits + .long 0x2c # Length of Address Ranges Info + .value 0x2 # DWARF aranges version + .long .Ldebug_info0 # Offset of Compilation Unit Info + .byte 0x8 # Size of Address + .byte 0 # Size of Segment Descriptor + .value 0 # Pad to 16 byte boundary ---------------- You can delete this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97721/new/ https://reviews.llvm.org/D97721 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
