labath added a comment.

Yeah, I'm with Greg. Although I would recommend using lit tests in general, I 
don't think they're a good fit for anything that involves attaching, or other 
kinds of inter-process synchronization. Once you start dealing with 
subprocesses you're entering very messy (and unportable) waters. Just make this 
a dotest test. You can base this off of one of the existing attach tests 
there...

> The lit test get stuck on // RUN: PID=$(%s.out). Not sure why, the parent 
> process shouldn't wait on its children..

I don't think this does what you think it does. The `$()` doesn't give you the 
process id of anything -- it substitutes a string by the result of running that 
string **as a shell command**. So, the PID variable would get the (entire) 
stdout of `%s.out`. Obviously, the command has to terminate in order for it to 
be able to compute that...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96637/new/

https://reviews.llvm.org/D96637

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to