[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

[Raphael Isemann via Phabricator via lldb-commits]

teemperor updated this revision to Diff 324551.
teemperor added a comment.

- Also clarify error message.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96939/new/

https://reviews.llvm.org/D96939

Files:
  lldb/source/Commands/CommandObjectTarget.cpp


Index: lldb/source/Commands/CommandObjectTarget.cpp
===================================================================
--- lldb/source/Commands/CommandObjectTarget.cpp
+++ lldb/source/Commands/CommandObjectTarget.cpp
@@ -425,8 +425,12 @@
           }
         } else {
           result.AppendErrorWithFormatv(
-              "Unable to find process plug-in for core file '{0}'\n",
+              "Couldn't recognize core file format of '{0}'\n",
               core_file.GetPath());
+          result.AppendMessage(
+              "note: If the file is a core file in a compressed file archive, "
+              "it first needs to be manually extracted before it can be "
+              "loaded.");
           result.SetStatus(eReturnStatusFailed);
         }
       } else {



Index: lldb/source/Commands/CommandObjectTarget.cpp
===================================================================
--- lldb/source/Commands/CommandObjectTarget.cpp
+++ lldb/source/Commands/CommandObjectTarget.cpp
@@ -425,8 +425,12 @@
           }
         } else {
           result.AppendErrorWithFormatv(
-              "Unable to find process plug-in for core file '{0}'\n",
+              "Couldn't recognize core file format of '{0}'\n",
               core_file.GetPath());
+          result.AppendMessage(
+              "note: If the file is a core file in a compressed file archive, "
+              "it first needs to be manually extracted before it can be "
+              "loaded.");
           result.SetStatus(eReturnStatusFailed);
         }
       } else {

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits