JDevlieghere added inline comments.
================ Comment at: lldb/include/lldb/Target/LanguageRuntime.h:177 + // A language runtime may be able to provide a special UnwindPlan for + // the frame represented by the register contents \a regctx when that ---------------- Please use `///` so this becomes a Doxygen comment. ================ Comment at: lldb/include/lldb/Target/LanguageRuntime.h:187 + static lldb::UnwindPlanSP + GetAsyncedFrameUnwindPlan(lldb_private::Thread &thread, + lldb_private::RegisterContext *regctx); ---------------- `s/Asynced/Async/` maybe? ================ Comment at: lldb/source/Target/RegisterContextUnwind.cpp:294 + // + // A Swift async function will have a normal UnwindPlan when it is + // executing, but it may be unscheduled (or on a different thread) ---------------- nit: This sounds like is supposed to be generic, I'd drop the Swift here, you already gave that as an example above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96839/new/ https://reviews.llvm.org/D96839 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
