DavidSpickett added inline comments.
================ Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1518 + Status error = NativeProcessLinux::PtraceWrapper( + details->ptrace_read_req, GetID(), + reinterpret_cast<void *>(range.GetRangeBase()), ---------------- omjavaid wrote: > Do you think future architectures will have any different > ptrace_read_req/ptrace_write_req than PTRACE_PEEKMTETAGS/PTRACE_POKEMTETAGS. > > If not then there is is no advantage of putting them inside > MemoryTaggingDetails Given that "MTE" is in the name, I would think yes. (though they might end up being aliases to the same number) I also want to avoid having AArch64 only (at the current time) constants in generic code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.llvm.org/D95601 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
