jrtc27 added inline comments.
================
Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:525-526
static const uint8_t g_s390x_opcode[] = {0x00, 0x01};
+ static const uint8_t g_ppc_opcode[] = {0x7f, 0xc0, 0x00, 0x08};
static const uint8_t g_ppc64le_opcode[] = {0x08, 0x00, 0xe0, 0x7f}; // trap
----------------
Why are these two different? Should it not always be `trap` ie `tw 31,0,0`? If
not that should be explained here. These names also aren't great as it's
unclear which ppc64 is using unless you read the code below (I'd expect either
ppc and ppc64 or ppc and ppcle as the two "axes", but ppc and ppc64le are on a
diagonal in the 2x2 grid).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95947/new/
https://reviews.llvm.org/D95947
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
