[Lldb-commits] [PATCH] D96201: [nfc] [lldb] Add Dwo assert

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil created this revision.
jankratochvil added a reviewer: labath.
jankratochvil added a project: LLDB.
Herald added a subscriber: JDevlieghere.
jankratochvil requested review of this revision.

I had it in my local patchset and I did not want to drop it, OK for check-in?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96201

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp


Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
===================================================================
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
@@ -532,6 +532,9 @@
   if (die_offset == DW_INVALID_OFFSET)
     return DWARFDIE(); // Not found
 
+  // SymbolFileDWARF::GetDIE should have found the dwo file already.
+  lldbassert(!GetDwoSymbolFile());
+
   if (!ContainsDIEOffset(die_offset)) {
     GetSymbolFileDWARF().GetObjectFile()->GetModule()->ReportError(
         "GetDIE for DIE 0x%" PRIx32 " is outside of its CU 0x%" PRIx32,



Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
===================================================================
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
@@ -532,6 +532,9 @@
   if (die_offset == DW_INVALID_OFFSET)
     return DWARFDIE(); // Not found
 
+  // SymbolFileDWARF::GetDIE should have found the dwo file already.
+  lldbassert(!GetDwoSymbolFile());
+
   if (!ContainsDIEOffset(die_offset)) {
     GetSymbolFileDWARF().GetObjectFile()->GetModule()->ReportError(
         "GetDIE for DIE 0x%" PRIx32 " is outside of its CU 0x%" PRIx32,

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits