JDevlieghere added inline comments.
================ Comment at: lldb/include/lldb/Interpreter/ScriptInterpreter.h:534 + virtual StructuredData::GenericSP + ScriptedProcess_CreatePluginObject(const char *class_name, + lldb::TargetSP target_sp, ---------------- JDevlieghere wrote: > It doesn't seem like these methods belong in ScriptInterpreter. Can they go > into their own class of which the ScriptInterpreter holds a single instance? Also, can this take a StringRef instead of a C string? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95711/new/ https://reviews.llvm.org/D95711 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
