djtodoro added a comment.
> Regarding the test, would it be possible to reuse one of the existing core
> files? (The reason we have so few core tests is because we used to not allow
> checked in core files at all -- now we kinda do, but it's still not ideal.)
> I'm guessing you don't even need to disassemble a function to reproduce this
> -- it should be sufficient to run `disassemble --start-address X
> --end-address Y`, where the region `X--Y` crosses a core segment boundary..
We can disassemble a region that crosses core segment boundary, e.g.:
(let's use
//lldb/test/API/functionalities/postmortem/elf-core/linux-x86_64.core//)
(lldb) disassemble --start 0x400161 --end 0x40100c
0x400161: addb %al, (%rax)
0x400163: addb %al, (%rax)
0x400165: addb %al, (%rax)
0x400167: addb %dl, (%rax,%rax)
0x40016a: addb %al, (%rax)
0x40016c: addb %al, (%rax)
0x40016e: addb %al, (%rax)
0x400170: addl %edi, 0x52(%rdx)
0x400173: addb %al, (%rcx)
0x400175: js 0x400187
0x400177: addl %ebx, (%rbx)
0x400179: orb $0x7, %al
0x40017b: orb %dl, 0x1c000001(%rax)
0x400181: addb %al, (%rax)
0x400183: addb %bl, (%rax,%rax)
0x400186: addb %al, (%rax)
0x400188: testb %bh, %bh
and this triggers the code for zero-bytes-filling. After applying this patch,
the output of the command is exactly the same.
I am not sure what should we check in the test if we use this existing
core-file, any idea?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93939/new/
https://reviews.llvm.org/D93939
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
