labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

LG, modulo inline comment.



================
Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.h:45-46
 
+  void ConfigureOffsets();
+
   size_t GetNumRegisters() const;
----------------
Users should not be calling this, right? Could we make this protected?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94008/new/

https://reviews.llvm.org/D94008

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits] [PAT... Muhammad Omair Javaid via Phabricator via lldb-commits
    • [Lldb-commits]... Pavel Labath via Phabricator via lldb-commits
    • [Lldb-commits]... Muhammad Omair Javaid via Phabricator via lldb-commits

Reply via email to