JDevlieghere added a comment. In D92820#2446091 <https://reviews.llvm.org/D92820#2446091>, @friss wrote:
> This LGTM. > There is one thing that you might want to address, but I'll leave it up to > you (and even if you do it can be a different commit): with the introduction > of `idx` variables, it becomes easy to get confused between `id` and `idx`(Or > `CheckID` and `CheckIndex`) in the codebase. Not sure how to disambiguate, or > if it's really worth it. Agreed, it's even more confusing because I also use `idx` for the object index. Let me rename this to sequence. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92820/new/ https://reviews.llvm.org/D92820 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
