mgorny added inline comments.
================ Comment at: lldb/test/Shell/Register/x86-fp-write.test:2 # XFAIL: system-windows -# REQUIRES: native && target-x86 +# REQUIRES: native && (target-x86 || target-x86_64) # RUN: %clangxx_host %p/Inputs/x86-fp-write.cpp -o %t ---------------- shafik wrote: > I removed `target-x86_64` in a fix this is failing on the green dragon build > bot: > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/24969/#showFailuresLink > > and I trying to get back green again. I don't think that's the correct solution here. Unless I'm mistaken, you've only implicitly skipping it per arch, while I'm pretty sure it would fail on i386 too. It really needs xfail on Darwin like the other test, I guess. It would be helpful if you could test whether adding `STi` as an alias to `STMMi` helps. It's not exactly helpful when platforms use different names for the same thing, and I don't have a Darwin env to test (and I don't think I can easily get one legally, can I?). I'm going to try submitting a guesswork patch for somebody to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91497/new/ https://reviews.llvm.org/D91497 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
