mgorny marked 3 inline comments as done.
mgorny added inline comments.
================
Comment at:
lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:151
-std::string NativeThreadFreeBSD::GetName() { return ""; }
+std::string NativeThreadFreeBSD::GetName() {
+ if (!m_thread_name) {
----------------
krytarowski wrote:
> It is probably fine, but I would use:
>
> 1. `PT_GETNUMLWPS`
> 2. `PT_GETLWPLIST` with optional caching
> 3. Read `pl_tdname` from `ptrace_lwpinfo`
`PT_GETLWPLIST` returns only LWP IDs. `struct ptrace_lwpinfo` is used by
`PT_LWPINFO` which returns info about the thread causing the process to stop,
not an arbitrary thread.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90298/new/
https://reviews.llvm.org/D90298
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
