mgorny added inline comments.
================ Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:192-193 + return Status("not implemented"); + if (m_state == eStateLaunching) + return Status(); + Status error = RemoveWatchpoint(addr); ---------------- labath wrote: > Are you actually using this state for anything? Should this be an assert? > Maybe `assert(m_state == eStateStopped)` even ? I don't know, I am a copy-paste monkey ;-). I've presumed LLDB core controls in which states the method will be called. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90102/new/ https://reviews.llvm.org/D90102 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits