labath added a comment.

I'm afraid I don't understand what you mean. Could you try to be more specific?

It's true that currently lldb client uses the register offsets provided by the 
server (if they are present), and this is a divergence from pure gdb-remote. 
Were it not for variable-sized registers, I might even say that it is a good 
one. What the current patch does though is add another exception to the rule. 
This exception means that the offset provided by the server may not actually be 
the definitive value -- the client may choose to override it based on some 
built-in knowledge (and then assume the server has the same knowledge).

My proposal is to avoid this exception, and make it such that the 
server-provided offset is always definitive. And in cases where a definitive 
answer cannot be provided, the server will just not send the offset over.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82863/new/

https://reviews.llvm.org/D82863

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to