wallace marked 2 inline comments as done. wallace added inline comments.
================ Comment at: lldb/test/API/commands/trace/TestTraceDumpInstructions.py:142-143 + substrs=['''thread #1: tid = 3842849, total instructions = 2 + [0] no memory mapped at this address + [1] no memory mapped at this address''']) + ---------------- wallace wrote: > clayborg wrote: > > We should be showing addresses here. It doesn't matter if they are mapped > > or not. This will happen for JIT'ed code. > I'll do this in a later diff. Currently libipt doesn't report the addresses > that it fails to decode, but I'm planning on making a patch on libipt to > support that. Already fixed, disregard this comment ================ Comment at: lldb/test/API/commands/trace/TestTraceDumpInstructions.py:163 + [ 3] 0x400654 + [ 4] no memory mapped at this address + [ 5] 0x400516 ---------------- wallace wrote: > clayborg wrote: > > Why aren't we showing the address here? We will run into cases, for > > possibly JIT'ed code where we won't have a section for an address, so we > > should still show the address > > > Repeating my message from above: > > > I'll do this in a later diff. Currently libipt doesn't report the addresses > > that it fails to decode, but I'm planning on making a patch on libipt to > > support that. > Already fixed, disregard this comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89283/new/ https://reviews.llvm.org/D89283 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
