JDevlieghere added inline comments.
================
Comment at: lldb/source/Utility/Args.cpp:178
+Args::Args(llvm::ArrayRef<llvm::StringRef> args) : Args() {
+ for (llvm::StringRef arg : args)
----------------
Maybe StringList should have a ctor that takes an `ArrayRef<StringRef>`, but
probably not worth the extra copies here.
================
Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:414
+ std::string HelpText =
+ "Use '" + Name + " --help' for a complete list of options.\n";
----------------
Should we extract this code into a utility that we can use here and in the lldb
driver?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89477/new/
https://reviews.llvm.org/D89477
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
