jasonmolenda added a comment.

Just to confirm one quick detail (I couldn't remember for sure and had to 
check) - if we strtoul will stop parsing when it finds a character outside the 
range of the specified base.  e.g. calling strtoul("0x100", nullptr, 10) will 
yield 0; strtoul("10f", nullptr, 10) will yield 10.

I think we should revert David's doc change to lldb-platform-packets.txt which 
says that either base10 or base16 can be used.  David, what do you think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89227/new/

https://reviews.llvm.org/D89227

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to