[Lldb-commits] [PATCH] D89181: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*

Michał Górny via Phabricator via lldb-commits Sat, 10 Oct 2020 00:25:37 -0700

mgorny created this revision.
mgorny added reviewers: emaste, krytarowski.
Herald added subscribers: atanasyan, nemanjai.
mgorny requested review of this revision.


https://reviews.llvm.org/D89181

Files:
  lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
  lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.h
  
lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h
  
lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.h
  lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.h

Index: lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.h
===================================================================
--- lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.h
+++ lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.h
@@ -22,13 +22,13 @@
       lldb_private::RegisterInfoInterface *register_info);
 
 protected:
-  bool ReadGPR();
+  bool ReadGPR() override;
 
-  bool ReadFPR();
+  bool ReadFPR() override;
 
-  bool WriteGPR();
+  bool WriteGPR() override;
 
-  bool WriteFPR();
+  bool WriteFPR() override;
 
   // lldb_private::RegisterContext
   bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
@@ -37,39 +37,39 @@
                      const lldb_private::RegisterValue &value);
 
   bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
-                    lldb_private::RegisterValue &value);
+                    lldb_private::RegisterValue &value) override;
 
   bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
-                     const lldb_private::RegisterValue &value);
+                     const lldb_private::RegisterValue &value) override;
 
-  bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp);
+  bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
 
-  bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp);
+  bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
 
   uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
-                                 bool write);
+                                 bool write) override;
 
-  bool ClearHardwareWatchpoint(uint32_t hw_index);
+  bool ClearHardwareWatchpoint(uint32_t hw_index) override;
 
-  bool HardwareSingleStep(bool enable);
+  bool HardwareSingleStep(bool enable) override;
 
   // POSIXBreakpointProtocol
-  bool UpdateAfterBreakpoint();
+  bool UpdateAfterBreakpoint() override;
 
-  unsigned GetRegisterIndexFromOffset(unsigned offset);
+  unsigned GetRegisterIndexFromOffset(unsigned offset) override;
 
-  bool IsWatchpointHit(uint32_t hw_index);
+  bool IsWatchpointHit(uint32_t hw_index) override;
 
-  bool ClearWatchpointHits();
+  bool ClearWatchpointHits() override;
 
-  lldb::addr_t GetWatchpointAddress(uint32_t hw_index);
+  lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
 
-  bool IsWatchpointVacant(uint32_t hw_index);
+  bool IsWatchpointVacant(uint32_t hw_index) override;
 
   bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
-                                      bool write, uint32_t hw_index);
+                                      bool write, uint32_t hw_index) override;
 
-  uint32_t NumSupportedHardwareWatchpoints();
+  uint32_t NumSupportedHardwareWatchpoints() override;
 
 private:
   ProcessMonitor &GetMonitor();
Index: lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.h
===================================================================
--- lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.h
+++ lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_powerpc.h
@@ -24,17 +24,17 @@
 protected:
   bool IsVMX();
 
-  bool ReadGPR();
+  bool ReadGPR() override;
 
-  bool ReadFPR();
+  bool ReadFPR() override;
 
-  bool ReadVMX();
+  bool ReadVMX() override;
 
-  bool WriteGPR();
+  bool WriteGPR() override;
 
-  bool WriteFPR();
+  bool WriteFPR() override;
 
-  bool WriteVMX();
+  bool WriteVMX() override;
 
   // lldb_private::RegisterContext
   bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
@@ -43,39 +43,39 @@
                      const lldb_private::RegisterValue &value);
 
   bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
-                    lldb_private::RegisterValue &value);
+                    lldb_private::RegisterValue &value) override;
 
   bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
-                     const lldb_private::RegisterValue &value);
+                     const lldb_private::RegisterValue &value) override;
 
-  bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp);
+  bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
 
-  bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp);
+  bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
 
   uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
-                                 bool write);
+                                 bool write) override;
 
-  bool ClearHardwareWatchpoint(uint32_t hw_index);
+  bool ClearHardwareWatchpoint(uint32_t hw_index) override;
 
-  bool HardwareSingleStep(bool enable);
+  bool HardwareSingleStep(bool enable) override;
 
   // POSIXBreakpointProtocol
-  bool UpdateAfterBreakpoint();
+  bool UpdateAfterBreakpoint() override;
 
-  unsigned GetRegisterIndexFromOffset(unsigned offset);
+  unsigned GetRegisterIndexFromOffset(unsigned offset) override;
 
-  bool IsWatchpointHit(uint32_t hw_index);
+  bool IsWatchpointHit(uint32_t hw_index) override;
 
-  bool ClearWatchpointHits();
+  bool ClearWatchpointHits() override;
 
-  lldb::addr_t GetWatchpointAddress(uint32_t hw_index);
+  lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
 
-  bool IsWatchpointVacant(uint32_t hw_index);
+  bool IsWatchpointVacant(uint32_t hw_index) override;
 
   bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
-                                      bool write, uint32_t hw_index);
+                                      bool write, uint32_t hw_index) override;
 
-  uint32_t NumSupportedHardwareWatchpoints();
+  uint32_t NumSupportedHardwareWatchpoints() override;
 
 private:
   ProcessMonitor &GetMonitor();
Index: lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h
===================================================================
--- lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h
+++ lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h
@@ -22,13 +22,13 @@
       lldb_private::RegisterInfoInterface *register_info);
 
 protected:
-  bool ReadGPR();
+  bool ReadGPR() override;
 
-  bool ReadFPR();
+  bool ReadFPR() override;
 
-  bool WriteGPR();
+  bool WriteGPR() override;
 
-  bool WriteFPR();
+  bool WriteFPR() override;
 
   // lldb_private::RegisterContext
   bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
@@ -37,39 +37,39 @@
                      const lldb_private::RegisterValue &value);
 
   bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
-                    lldb_private::RegisterValue &value);
+                    lldb_private::RegisterValue &value) override;
 
   bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
-                     const lldb_private::RegisterValue &value);
+                     const lldb_private::RegisterValue &value) override;
 
-  bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp);
+  bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
 
-  bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp);
+  bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
 
   uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
-                                 bool write);
+                                 bool write) override;
 
-  bool ClearHardwareWatchpoint(uint32_t hw_index);
+  bool ClearHardwareWatchpoint(uint32_t hw_index) override;
 
-  bool HardwareSingleStep(bool enable);
+  bool HardwareSingleStep(bool enable) override;
 
   // POSIXBreakpointProtocol
-  bool UpdateAfterBreakpoint();
+  bool UpdateAfterBreakpoint() override;
 
-  unsigned GetRegisterIndexFromOffset(unsigned offset);
+  unsigned GetRegisterIndexFromOffset(unsigned offset) override;
 
-  bool IsWatchpointHit(uint32_t hw_index);
+  bool IsWatchpointHit(uint32_t hw_index) override;
 
-  bool ClearWatchpointHits();
+  bool ClearWatchpointHits() override;
 
-  lldb::addr_t GetWatchpointAddress(uint32_t hw_index);
+  lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
 
-  bool IsWatchpointVacant(uint32_t hw_index);
+  bool IsWatchpointVacant(uint32_t hw_index) override;
 
   bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
-                                      bool write, uint32_t hw_index);
+                                      bool write, uint32_t hw_index) override;
 
-  uint32_t NumSupportedHardwareWatchpoints();
+  uint32_t NumSupportedHardwareWatchpoints() override;
 
 private:
   uint64_t 
Index: lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.h
===================================================================
--- lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.h
+++ lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm64.h
@@ -21,13 +21,13 @@
       std::unique_ptr<RegisterInfoPOSIX_arm64> register_info);
 
 protected:
-  bool ReadGPR();
+  bool ReadGPR() override;
 
-  bool ReadFPR();
+  bool ReadFPR() override;
 
-  bool WriteGPR();
+  bool WriteGPR() override;
 
-  bool WriteFPR();
+  bool WriteFPR() override;
 
   // lldb_private::RegisterContext
   bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
@@ -36,39 +36,39 @@
                      const lldb_private::RegisterValue &value);
 
   bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
-                    lldb_private::RegisterValue &value);
+                    lldb_private::RegisterValue &value) override;
 
   bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
-                     const lldb_private::RegisterValue &value);
+                     const lldb_private::RegisterValue &value) override;
 
-  bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp);
+  bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
 
-  bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp);
+  bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
 
   uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
-                                 bool write);
+                                 bool write) override;
 
-  bool ClearHardwareWatchpoint(uint32_t hw_index);
+  bool ClearHardwareWatchpoint(uint32_t hw_index) override;
 
-  bool HardwareSingleStep(bool enable);
+  bool HardwareSingleStep(bool enable) override;
 
   // POSIXBreakpointProtocol
-  bool UpdateAfterBreakpoint();
+  bool UpdateAfterBreakpoint() override;
 
-  unsigned GetRegisterIndexFromOffset(unsigned offset);
+  unsigned GetRegisterIndexFromOffset(unsigned offset) override;
 
-  bool IsWatchpointHit(uint32_t hw_index);
+  bool IsWatchpointHit(uint32_t hw_index) override;
 
-  bool ClearWatchpointHits();
+  bool ClearWatchpointHits() override;
 
-  lldb::addr_t GetWatchpointAddress(uint32_t hw_index);
+  lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
 
-  bool IsWatchpointVacant(uint32_t hw_index);
+  bool IsWatchpointVacant(uint32_t hw_index) override;
 
   bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
-                                      bool write, uint32_t hw_index);
+                                      bool write, uint32_t hw_index) override;
 
-  uint32_t NumSupportedHardwareWatchpoints();
+  uint32_t NumSupportedHardwareWatchpoints() override;
 
 private:
   RegisterInfoPOSIX_arm64::GPR m_gpr_arm64; // 64-bit general purpose registers.
Index: lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
===================================================================
--- lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
+++ lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_arm.h
@@ -20,13 +20,13 @@
       std::unique_ptr<RegisterInfoPOSIX_arm> register_info);
 
 protected:
-  bool ReadGPR();
+  bool ReadGPR() override;
 
-  bool ReadFPR();
+  bool ReadFPR() override;
 
-  bool WriteGPR();
+  bool WriteGPR() override;
 
-  bool WriteFPR();
+  bool WriteFPR() override;
 
   // lldb_private::RegisterContext
   bool ReadRegister(const unsigned reg, lldb_private::RegisterValue &value);
@@ -35,39 +35,39 @@
                      const lldb_private::RegisterValue &value);
 
   bool ReadRegister(const lldb_private::RegisterInfo *reg_info,
-                    lldb_private::RegisterValue &value);
+                    lldb_private::RegisterValue &value) override;
 
   bool WriteRegister(const lldb_private::RegisterInfo *reg_info,
-                     const lldb_private::RegisterValue &value);
+                     const lldb_private::RegisterValue &value) override;
 
-  bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp);
+  bool ReadAllRegisterValues(lldb::DataBufferSP &data_sp) override;
 
-  bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp);
+  bool WriteAllRegisterValues(const lldb::DataBufferSP &data_sp) override;
 
   uint32_t SetHardwareWatchpoint(lldb::addr_t addr, size_t size, bool read,
-                                 bool write);
+                                 bool write) override;
 
-  bool ClearHardwareWatchpoint(uint32_t hw_index);
+  bool ClearHardwareWatchpoint(uint32_t hw_index) override;
 
-  bool HardwareSingleStep(bool enable);
+  bool HardwareSingleStep(bool enable) override;
 
   // POSIXBreakpointProtocol
-  bool UpdateAfterBreakpoint();
+  bool UpdateAfterBreakpoint() override;
 
-  unsigned GetRegisterIndexFromOffset(unsigned offset);
+  unsigned GetRegisterIndexFromOffset(unsigned offset) override;
 
-  bool IsWatchpointHit(uint32_t hw_index);
+  bool IsWatchpointHit(uint32_t hw_index) override;
 
-  bool ClearWatchpointHits();
+  bool ClearWatchpointHits() override;
 
-  lldb::addr_t GetWatchpointAddress(uint32_t hw_index);
+  lldb::addr_t GetWatchpointAddress(uint32_t hw_index) override;
 
-  bool IsWatchpointVacant(uint32_t hw_index);
+  bool IsWatchpointVacant(uint32_t hw_index) override;
 
   bool SetHardwareWatchpointWithIndex(lldb::addr_t addr, size_t size, bool read,
-                                      bool write, uint32_t hw_index);
+                                      bool write, uint32_t hw_index) override;
 
-  uint32_t NumSupportedHardwareWatchpoints();
+  uint32_t NumSupportedHardwareWatchpoints() override;
 
 private:
   RegisterInfoPOSIX_arm::GPR m_gpr_arm;

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D89181: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*

Reply via email to