aprantl added inline comments.
================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:405
+ auto find_sdk = [&](std::string sdk_name) -> std::string {
+ std::string developer_dir = GetEnvDeveloperDir();
+ if (developer_dir.empty())
----------------
perhaps add
```
bool have_developer_dir = !developer_dir.empty()`
```
================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:427
+ // If we didn't find the SDK with the developer dir set, try without.
+ return xcrun(xcrun_cmd);
+ };
----------------
and here `if (!have_developer_dir)`
to avoid silently ignoring an explicitly specified DEVELOPER_DIR
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88866/new/
https://reviews.llvm.org/D88866
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
