> On Oct 6, 2020, at 8:40 AM, Pavel Labath via Phabricator via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > labath added a comment. > > In D88840#2314587 <https://reviews.llvm.org/D88840#2314587>, @rupprecht wrote: > >> In D88840#2313331 <https://reviews.llvm.org/D88840#2313331>, @kastiglione >> wrote: >> >>> About `-P`, the man page for `lldb` and the driver's `Options.td` say it: >>> >>>> Prints out the path to the lldb.py file for this version of lldb. >>> >>> Should it do just that? If so this can be simplified further. >> >> It can print the path, or it can print `<COULD NOT FIND PATH>` if e.g. lldb >> wasn't built with python support or has some non-standard python setup. So I >> think this is basically as simple as the parsing can get. > > One way this could be simplified further is to ditch `-P` and pass down the > appropriate value from cmake/lit.
-P is not just for running the testsuite, it’s a way for users to set up their PYTHONPATH for lldb standalone scripts. So far as I can see at present it’s only tested by dotest relying on its having a good value. So if we aren’t going to use it in dotest we need to write some explicit tests for it. Jim > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D88840/new/ > > https://reviews.llvm.org/D88840 > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
