labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
This is great. Thanks. ================ Comment at: lldb/test/Shell/Register/x86-fp-read.test:7 +register read --all +# CHECK-DAG: fctrl = 0x037e +# CHECK-DAG: fstat = 0x88c1 ---------------- Maybe add a `# CHECK: Process {{.*}} stopped` line here. That will restrict the following CHECK-DAGs to match after it, which will make FileCheck output more useful. Without it, FileCheck's "Searching from here" snippet will start at the very beginning of the lldb output, which will not be very helpful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88583/new/ https://reviews.llvm.org/D88583 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits