DavidSpickett added a reviewer: omjavaid.
DavidSpickett added a comment.

What isn't covered in testing is checking that "memory region" will not print 
"flags:" if there aren't any. This would need a way to make a fake lldbserver 
that didn't reply with the flags field, I could write tests that expect the 
"flags:" but then when you ran them on a different kernel they might fail. 
Perhaps there is a way to replay a gdb comms session to lldb instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87442/new/

https://reviews.llvm.org/D87442

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to