aadsm added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:441 + if (first_code_section_sp) + m_first_code_address = first_code_section_sp->GetFileAddress(); +} ---------------- I'm actually not 100% sure about this, can there be new code sections added after this? ================ Comment at: lldb/unittests/SymbolFile/DWARF/Inputs/test-invalid-offsets.yaml:520 + Data: 0 +... ---------------- I generated this yaml with the code that is at the top, and then changed it to replicate the bug ,here's what the line table looks like: ``` Address Line Column File ISA Discriminator Flags ------------------ ------ ------ ------ --- ------------- ------------- 0x0000000100000f80 1 0 1 0 0 is_stmt 0x0000000100000f84 2 5 1 0 0 is_stmt prologue_end 0x0000000100000f8b 2 5 1 0 0 is_stmt end_sequence 0x0000000100000f90 5 0 1 0 0 is_stmt 0x0000000100000f90 5 0 1 0 0 is_stmt end_sequence 0x000000000000000f 2 13 1 0 0 is_stmt prologue_end 0x0000000000000014 2 9 1 0 0 0x0000000000000017 3 12 1 0 0 is_stmt 0x000000000000001d 3 12 1 0 0 end_sequence ``` Now that I think about it maybe I should also copy this into this file as a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87172/new/ https://reviews.llvm.org/D87172 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
