clayborg added a comment. In D85705#2237397 <https://reviews.llvm.org/D85705#2237397>, @JDevlieghere wrote:
> A large part of this patch is concerned with parsing which worries me from a > maintenance perspective. Did you consider using Yaml I/O > <https://llvm.org/docs/YamlIO.html>? While I'm not a particularly big fan of > the format, the benefits of being able to (de)serialize any class by > implementing the appropriate traits are quite significant. We already have > traits implemented for a bunch of utility classes, such as `ArchSpec` and > `FileSpec` which we could reuse for this. I know changing the format would be > invasive, but I think it might be worth it in the long term. So the nice thing about using StructuredData is it can be in any format: JSON, XML, Apple property list, YAML etc. It seems like the functions that were added to ArchSpec and FileSpec for the YAML I/O could be converted to use StructuredData and then any of the formats would work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85705/new/ https://reviews.llvm.org/D85705 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
