clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed.
Patch looks good. Just need to test 32 bit RISC as well with a "lldb/test/Shell/ObjectFile/ELF/riscv32-arch.yaml" to verify 32 bit is working. ================ Comment at: lldb/test/Shell/ObjectFile/ELF/riscv64-arch.yaml:1-11 +# RUN: yaml2obj %s > %t +# RUN: lldb-test object-file %t | FileCheck %s + +# CHECK: Architecture: riscv64-- + +--- !ELF +FileHeader: ---------------- We should test 32 bit as well right? Or do we already have one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86292/new/ https://reviews.llvm.org/D86292 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
