JDevlieghere added a comment. I didn't look at the scripts in detail but I have a few general (high level) comments:
- I also feel this should go under `lldb/scripts`. - Can we put the documentations as RST under `lldb/docs` so it's rendered on the website? We already have bunch of developer resources there. That will certainly help with discovery. - LLVM generally encourages scripts to be written in Python. While it doesn't look like this will work out of the box on Windows, I can imagine someone might be interested in that down the line. I also think the bar is lower for new contributors to write Python than bash. I'm kind of on the fence here because there's a reasonable balance between just running commands and control flow, but then I've been scarred by the `build-script-impl` disaster in Swift so I lean towards better safe than sorry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82064/new/ https://reviews.llvm.org/D82064 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
