clayborg created this revision.
clayborg added reviewers: labath, aprantl, JDevlieghere.
Herald added a project: LLDB.
clayborg requested review of this revision.
Checking if an object file is in memory should use the
ObjectFile::IsInMemory(), not test ObjectFile::BaseAddress().
ObjectFile::BaseAddress() is designed to be overridden by all classes and is
for mach-o, ELF and COFF plug-ins. They find the header base adddress and
return that as a section offset address. The default implementation of
ObjectFile::BaseAddress() does try and make an Address() from the
ObjectFile::m_memory_addr, but I switched it to a correct function call.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D86122
Files:
lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
Index: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
===================================================================
--- lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -1628,7 +1628,7 @@
} else if (unified_section_sp) {
if (is_dsym && unified_section_sp->GetFileAddress() != load_cmd.vmaddr) {
// Check to see if the module was read from memory?
- if (module_sp->GetObjectFile()->GetBaseAddress().IsValid()) {
+ if (module_sp->GetObjectFile()->IsInMemory()) {
// We have a module that is in memory and needs to have its file
// address adjusted. We need to do this because when we load a file
// from memory, its addresses will be slid already, yet the addresses
Index: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
===================================================================
--- lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
+++ lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
@@ -1628,7 +1628,7 @@
} else if (unified_section_sp) {
if (is_dsym && unified_section_sp->GetFileAddress() != load_cmd.vmaddr) {
// Check to see if the module was read from memory?
- if (module_sp->GetObjectFile()->GetBaseAddress().IsValid()) {
+ if (module_sp->GetObjectFile()->IsInMemory()) {
// We have a module that is in memory and needs to have its file
// address adjusted. We need to do this because when we load a file
// from memory, its addresses will be slid already, yet the addresses
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
