Author: Jonas Devlieghere Date: 2020-08-17T09:20:20-07:00 New Revision: a0a328ed4fda83513ac0e1d9d30650e9b6b63d20
URL: https://github.com/llvm/llvm-project/commit/a0a328ed4fda83513ac0e1d9d30650e9b6b63d20 DIFF: https://github.com/llvm/llvm-project/commit/a0a328ed4fda83513ac0e1d9d30650e9b6b63d20.diff LOG: [lldb] Fix and re-enable TestMultipleDebuggers The comment says that TestMultipleDebuggers was XFAILed because it was failing nondeterministically in which case it should be skipped not failed (as XPASS will cause the test suite to fail). The reason it fails is because it was not marked as a no-debug-info test case. I've ran the test in a loop and it has been passing consistently. Let's enable it and see if the bots agree, if not we can skip it. Added: Modified: lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py Removed: ################################################################################ diff --git a/lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py b/lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py index 1447bbdfe42f..83d27074cef4 100644 --- a/lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py +++ b/lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py @@ -15,9 +15,9 @@ class TestMultipleSimultaneousDebuggers(TestBase): mydir = TestBase.compute_mydir(__file__) - # This test case fails non-deterministically. + NO_DEBUG_INFO_TESTCASE = True + @skipIfNoSBHeaders - @expectedFailureAll(bugnumber="llvm.org/pr20282") def test_multiple_debuggers(self): env = {self.dylibPath: self.getLLDBLibraryEnvVal()} @@ -30,9 +30,9 @@ def test_multiple_debuggers(self): self.buildDriver('testprog.cpp', self.inferior_exe) self.addTearDownHook(lambda: os.remove(self.inferior_exe)) -# check_call will raise a CalledProcessError if multi-process-driver doesn't return -# exit code 0 to indicate success. We can let this exception go - the test harness -# will recognize it as a test failure. + # check_call will raise a CalledProcessError if multi-process-driver + # doesn't return exit code 0 to indicate success. We can let this + # exception go - the test harness will recognize it as a test failure. if self.TraceOn(): print("Running test %s" % self.driver_exe) _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
