JDevlieghere added inline comments.
================ Comment at: lldb/include/lldb/Utility/Scalar.h:258 + static Type PromoteToMaxType(const Scalar &lhs, const Scalar &rhs, + Scalar &temp_value, ---------------- I really hate this signature. How do you feel about having this return a struct with the Type, the temp Scalar and the two references? That doesn't have to be part of this patch though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85836/new/ https://reviews.llvm.org/D85836 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
