aprantl added inline comments.
================
Comment at: lldb/source/Target/TargetList.cpp:110-111
+ // architecture so that the platform matching can be more accurate.
+ if (!platform_arch.TripleOSWasSpecified() ||
+ !platform_arch.TripleVendorWasSpecified()) {
+ prefer_platform_arch = true;
----------------
davide wrote:
> Is this check strict enough? I thought it should be only TripleOSWasSpecified
> -- what we can infer from the vendor?
Git archeology says that this comes from
3f19ada88e24008b24a5db20b7f78f5cff525a0b / SVN r212783.
Quoting: `- Fixed the coded in TargetList::CreateTarget() so it does the right
thing with an underspecified triple where just the arch is specified.`
I think it's specifically supposed to detect a triple with just a CPU, which is
what we get from `target create --arch`. I think your comment still rings true.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85049/new/
https://reviews.llvm.org/D85049
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
