simoncook added a comment.
Herald added a subscriber: JDevlieghere.

Thanks for looking at this @luismarques We had planned to put more effort into 
this patch, but time got in the way for quite a lot, but I'm glad it's working; 
thanks for the rebase I'll update this to match shortly. And it's good that it 
looks like it's mostly working. I'm curious about your backtrace showing one 
frame, is that something without debug information, since the example I was 
using when writing this did show a backtrace back to main? It would be good to 
understand why that disn't produce the expected output.

As for next steps, if we're happy with the state then I think this should land 
(assuming qemu is sufficient given it is public), and then we can flesh out 
other bits which give a better experience. I'm not sure how to connect this to 
any automated testing, or where to document any way of checking this manually, 
the state of that isn't quite clear, so any clarity there helps.

Beyond this I think the next stage is implementing the parts for calling 
functions within a target, which if you could help with that would be great. I 
see that as a follow up patch to this, I don't see the two necessarily having 
to land together, since this part enables a useful debugging experience already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62732/new/

https://reviews.llvm.org/D62732

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to