llunak added a comment.

In D68908#2174222 <https://reviews.llvm.org/D68908#2174222>, @clayborg wrote:

> If removing 'd' was only to make it available for "up" and "down" in 
> https://reviews.llvm.org/D68541, then maybe we should switch 'D' to "detach 
> and let run? Or is that what we did, but the comment on line 4331 is now out 
> of date?

Making 'd' available for "down" was the original motivation, but not having 
single-key shortcuts with "dangerous" seemed like a good thing on its own (or 
maybe I thought I needed strong arguments for reassigning 'd', I don't quite 
remember). I don't have a strong opinion on 'D'. On the one hand shift+d is 
harder to hit by accident. On the other hand that's still somewhat possible, 
the action is still available as 'F3 <https://reviews.llvm.org/F3>,d' in the 
menu, and gdb tui does not seem to have a single "dangerous" shortcut 
(according to 
https://sourceware.org/gdb/onlinedocs/gdb/TUI-Single-Key-Mode.html). And I've 
never used the detach action, so I'd prefer if somebody else decided this.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68908/new/

https://reviews.llvm.org/D68908

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to