On Thu, Jul 23, 2020 at 00:20 Pavel Labath <pa...@labath.sk> wrote:
> On 22/07/2020 22:56, Jonas Devlieghere via lldb-commits wrote:
> > - ConstString operator=(ConstString rhs) {
> > + ConstString operator=(const ConstString &rhs) {
>
> ConstString is trivially copyable (well, it has a user defined copy
> constructor but it is trivial...).
>
> Plus, not so long ago (D59030) we changed all `const ConstString &`s to
> plain `ConstString`. It would be good to avoid flipping this back and
> forth all the time.
Thanks for reminding me, I had totally forgotten about that patch. I’ll
take care of that tomorrow.
--
Sent from my iPhone
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
