[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

I was testing out how `NSStringSummaryProvider` deals w/ `NULL` using `NSString 
*foo = nullptr` and we filter out `NULL` values in 
`ValueObjectPrinter::GetValueSummaryError(...)` :

  if (IsNil())
        summary.assign("nil");

That should mean that the `text->GetValueAsUnsigned(0) == 0` is not necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84272/new/

https://reviews.llvm.org/D84272



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits