jingham marked 2 inline comments as done. jingham added inline comments.
================ Comment at: lldb/include/lldb/Interpreter/OptionValueFileColonLine.h:43 + m_line_number = LLDB_INVALID_LINE_NUMBER; + m_column_number = 0; + } ---------------- JDevlieghere wrote: > This should be `LLDB_INVALID_COLUMN_NUMBER` and probably also be `UINT32_MAX` > unless we rely on it being 0 anywhere? The code before this change was using 0 as the invalid value, and there was no define. I added the define and set it to 0, but I haven't propagated that everywhere it is used. That's an orthogonal cleanup which I'd rather do separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83975/new/ https://reviews.llvm.org/D83975 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
