labath added a comment. In D83425#2154593 <https://reviews.llvm.org/D83425#2154593>, @bbli wrote:
> Ok, I have revised the patch with the code from the first pic. I also moved > the `decode` back to the `format_build_error` since it was there to begin > with(not sure how much of a difference it makes). Also while we finalize this > patch, is there another fix I can get started on? Sure. I don't want to bore you with something too menial. How big of a project would you be interested in? One thing that would be very helpful is to come up with some kind of a strategy for testing the "gui" mode of lldb, as we currently have no good way of testing that. I've described one idea in https://reviews.llvm.org/D82522#2113608, but I'm open to other options too.... ================ Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:444 "stdout_content": this_output, "stderr_content": this_error, "command": shellCommand ---------------- Setting this no longer makes sense, as it will always be empty. Please remove that. Maybe also rename stdout_content to indicate it also contains stderr. Just plain "output" might suffice? ================ Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:450 error = error + this_error.decode("utf-8") return (output, error) ---------------- this error result also doesn't make sense. It looks like you'll also need to update the usage in `getCompilerVersion` (line 1276). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83425/new/ https://reviews.llvm.org/D83425 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
