MaskRay added a subscriber: mehdi_amini. MaskRay added a comment. In D82477#2145967 <https://reviews.llvm.org/D82477#2145967>, @clayborg wrote:
> In D82477#2145565 <https://reviews.llvm.org/D82477#2145565>, @MaskRay wrote: > > > Hi, your git commit contains extra Phabricator tags. You can drop > > `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git > > commit with the following script: > > > > arcfilter () { > > arc amend > > git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} > > /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ > > {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F - > > } > > > > > > `Reviewed By: ` is considered important by some people. Please keep the > > tag. (`--date=now` is my personal preference (author dates are usually not > > useful. Using committer dates can make log almost monotonic in time)) > > > > `llvm/utils/git/pre-push.py` can validate the message does not include > > unneeded tags. > > > Can we modify this script to remove the unneeded tags instead of detecting it? @mehdi_amini ^^ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
